revert: force Highcharts to redraw when container's width changes (#580) #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be an issue with the workflows not being triggered, let's not merge before we can get them to run. |
sissbruecker
force-pushed
the
revert/highcharts_reflow_fix
branch
2 times, most recently
from
8280b16 to
a0e70be
Compare
|
Workflows have now run successfully. |
web-padawan
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a42945e
Reverts the previous fix for resizing the chart when wrapping it in a flex child, as it introduced several regressions (vaadin/web-components#2600). See vaadin/web-components#2171 (comment) for the resolution of the original issue.
I kept all the changes to the tests (unrelated to the fix), I assume they were done to make the tests more stable.