fix: sanitize options passed to HC methods #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to fix the P3 build. |
DiegoCardoso
force-pushed
the
fix/sanitize-options
branch
from
7af197c to
729dcd1
Compare
yuriy-fix
force-pushed
the
fix/sanitize-options
branch
from
1fd9029 to
85431fe
Compare
yuriy-fix
force-pushed
the
fix/sanitize-options
branch
from
9f753fb to
285973d
Compare
|
Build is green again thanks to @yuriy-fix, so I am marking this PR ready for review again. |
web-padawan
approved these changes
Apr 18, 2024
tomivirkki
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply the workaround described here on the methods that use options in Highcharts to sanitize them and prevent any unwanted script to be executed.
We must do it like this because Highcharts cannot be updated to V9+ in
Chartsfor V14.Fixes vaadin/web-components#7294
Type of change