fix: set aria-hidden="true" on prefix and suffix (#5049) (#5053)

Co-authored-by: Serhii Kulykov <[email protected]>
vaadin · Nov 18, 2022 · 04a1e5b · 04a1e5b
1 parent 2f7c7b5
commit 04a1e5b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/packages/button/src/vaadin-button.js b/packages/button/src/vaadin-button.js
@@ -117,13 +117,13 @@ class Button extends ActiveMixin(TabindexMixin(FocusMixin(ElementMixin(ThemableM
         }
       </style>
       <div class="vaadin-button-container">
-        <span part="prefix">
+        <span part="prefix" aria-hidden="true">
           <slot name="prefix"></slot>
         </span>
         <span part="label">
           <slot></slot>
         </span>
-        <span part="suffix">
+        <span part="suffix" aria-hidden="true">
           <slot name="suffix"></slot>
         </span>
       </div>

diff --git a/packages/button/test/dom/__snapshots__/button.test.snap.js b/packages/button/test/dom/__snapshots__/button.test.snap.js
@@ -79,15 +79,21 @@ snapshots["vaadin-button host active"] =
 
 snapshots["vaadin-button shadow default"] = 
 `<div class="vaadin-button-container">
-  <span part="prefix">
+  <span
+    aria-hidden="true"
+    part="prefix"
+  >
     <slot name="prefix">
     </slot>
   </span>
   <span part="label">
     <slot>
     </slot>
   </span>
-  <span part="suffix">
+  <span
+    aria-hidden="true"
+    part="suffix"
+  >
     <slot name="suffix">
     </slot>
   </span>