fix: do not throw error with incorrect value attribute (#4176) (#4178)

Co-authored-by: Serhii Kulykov <[email protected]>
vaadin · Jul 12, 2022 · 5c4b7b9 · 5c4b7b9
1 parent 6cd5def
commit 5c4b7b9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/time-picker/src/vaadin-time-picker.js b/packages/time-picker/src/vaadin-time-picker.js
@@ -549,7 +549,7 @@ class TimePicker extends PatternMixin(InputControlMixin(ThemableMixin(ElementMix
     const newValue = this.__formatISO(parsedObj) || '';
 
     if (this.value !== '' && this.value !== null && !parsedObj) {
-      this.value = oldValue;
+      this.value = oldValue === undefined ? '' : oldValue;
     } else if (this.value !== newValue) {
       this.value = newValue;
     } else {

diff --git a/packages/time-picker/test/form-input.test.js b/packages/time-picker/test/form-input.test.js
@@ -185,4 +185,10 @@ describe('form input', () => {
       expect(timePicker.invalid).to.equal(false);
     });
   });
+
+  describe('incorrect value', () => {
+    it('should not throw error when setting incorrect value using attribute', () => {
+      expect(() => fixtureSync(`<vaadin-time-picker value="1500"></vaadin-time-picker>`)).to.not.throw(Error);
+    });
+  });
 });