apply code review suggestions

vaadin · Apr 1, 2022 · ee345e6 · ee345e6
1 parent ead6e1b
commit ee345e6
Showing 1 changed file with 5 additions and 12 deletions.
diff --git a/packages/field-base/src/delegate-focus-mixin.js b/packages/field-base/src/delegate-focus-mixin.js
@@ -33,6 +33,8 @@ export const DelegateFocusMixin = dedupingMixin(
            * Any component implementing this mixin is expected to provide it
            * by using `this._setFocusElement(input)` Polymer API.
            *
+           * Toggling `tabindex` attribute on the host element propagates its value to `focusElement`.
+           *
            * @protected
            * @type {!HTMLElement}
            */
@@ -43,19 +45,10 @@ export const DelegateFocusMixin = dedupingMixin(
           },
 
           /**
-           * Indicates whether the element can be focused and where it participates in sequential keyboard navigation.
+           * Override the property from `TabIndexMixin`
+           * to ensure the `tabindex` attribute of the focus element
+           * is restored to `0` after re-enabling the element.
            *
-           * By default, the host element does not have tabindex attribute. Instead, `focusElement` should have it.
-           * Toggling `tabindex` attribute on the host element propagates its value to `focusElement`.
-           *
-           * @override
-           * @protected
-           */
-          tabindex: {
-            type: Number
-          },
-
-          /**
            * @protected
            * @override
            */