refactor: set role attribute directly in template (#7318)

vaadin · Apr 11, 2024 · ff30a54 · ff30a54
1 parent 7a4c80c
commit ff30a54
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/packages/dialog/src/vaadin-dialog.js b/packages/dialog/src/vaadin-dialog.js
@@ -103,6 +103,7 @@ class Dialog extends DialogDraggableMixin(
 
       <vaadin-dialog-overlay
         id="overlay"
+        role="dialog"
         header-title="[[headerTitle]]"
         on-opened-changed="_onOverlayOpened"
         on-mousedown="_bringOverlayToFront"
@@ -147,8 +148,6 @@ class Dialog extends DialogDraggableMixin(
   ready() {
     super.ready();
 
-    this._overlayElement.setAttribute('role', 'dialog');
-
     processTemplates(this);
   }
 

diff --git a/packages/dialog/src/vaadin-lit-dialog.js b/packages/dialog/src/vaadin-lit-dialog.js
@@ -72,6 +72,7 @@ class Dialog extends DialogDraggableMixin(
     return html`
       <vaadin-dialog-overlay
         id="overlay"
+        role="dialog"
         .owner="${this}"
         .opened="${this.opened}"
         .headerTitle="${this.headerTitle}"
@@ -91,13 +92,6 @@ class Dialog extends DialogDraggableMixin(
       ></vaadin-dialog-overlay>
     `;
   }
-
-  /** @protected */
-  ready() {
-    super.ready();
-
-    this._overlayElement.setAttribute('role', 'dialog');
-  }
 }
 
 defineCustomElement(Dialog);