Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: set role attribute directly in template #7318

Merged
merged 1 commit into from
Apr 11, 2024
Merged

refactor: set role attribute directly in template #7318

merged 1 commit into from
Apr 11, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Apr 11, 2024 •
edited
Loading

Description

The PR updates the dialog to set the role attribute directly in the template rather than in the ready() method.

Type of change

  • Refactor

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vursen vursen changed the title refactor: set role attribute in template refactor: set role attribute directly in template Apr 11, 2024
@vursen vursen merged commit ff30a54 into main Apr 11, 2024
9 checks passed
@vursen vursen deleted the refactor/dialog/move-role-attr-to-template branch April 11, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vursen @web-padawan