Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[login] Unable to show a login overlay defined in a LitTemplate #2125

Closed
Artur- opened this issue Jun 17, 2021 · 3 comments · Fixed by #3648
Closed

[login] Unable to show a login overlay defined in a LitTemplate #2125

Artur- opened this issue Jun 17, 2021 · 3 comments · Fixed by #3648

Comments

@Artur-
Copy link
Member

Artur- commented Jun 17, 2021

Description

A <vaadin-login-overlay> added in a LitTemplate cannot be shown.

No matter if you define it as <vaadin-login-overlay opened> or show it using Java as

public class MyTemplate extends LitTemplate {

@Id
private LoginOverlay login;

  public MyTemplate() {
    login.setOpened(true);
  }
}

Expected outcome

The login overlay is shown

Actual outcome

The login overlay is not shown

Minimal reproducible example

Steps to reproduce

git clone https://github.com/Artur-/test-login-overlay.git
cd test-login-overlay
mvn

Open http://localhost:8080/login-v1 or http://localhost:8080/login-v2

If you open http://localhost:8080/ and click on the link for login-v1 or login-v2, then it renders as expected

Environment

  • Vaadin 20.0.3
  • mac
@Artur-
Copy link
Member Author

Artur- commented Jun 17, 2021

Note that this works fine with Vaadin 14.x

@Artur-
Copy link
Member Author

Artur- commented Jun 17, 2021

One of the reasons seems to be that whenever a <vaadin-login-overlay> is moved in the DOM, it is closed

@web-padawan web-padawan changed the title Unable to show a login overlay defined in a LitTemplate [login] Unable to show a login overlay defined in a LitTemplate Jun 19, 2021
@vlukashov
Copy link

Possibly related: vaadin/flow-components#841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants