fix: restore overlay opened state when moving within the DOM

[sissbruecker]

Description

Restores overlay opened state when disconnecting and then reconnecting the element, for example when moving the element in the DOM. Applies to vaadin-dialog and vaadin-login-overlay.

Fixes vaadin/flow-components#2979
Fixes vaadin/flow-components#2087
Fixes #2125

Type of change

• Bugfix

[vursen]

Although I'm generally not very happy about solutions based on setTimeout, this case can probably be considered special as I don't think someone would rely on the synchronous closing of the dialog when it is disconnected. At least, I couldn't come up with a case where it might cause a problem. So looks good to me.

An alternative could be something like:

class Dialog {
  connectedCallback() {
    super.connectedCallback();

    if (this.__restoreOpened) {
      this.opened = true;
    }
  }

  disconnectedCallback() {
    super.disconnectedCallback();
    
    if (this.opened) {
      this.__restoreOpened = true;
      this.opened = false;
    }
  }
}

That would open / close the dialog synchronously but that solution is surely less laconic, compared to setTimeout.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[vaadin-bot]

This ticket/PR has been released with Vaadin 23.1.0.alpha2 and is also targeting the upcoming stable 23.1.0 version.