Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create helpers for using Lit templates instead of renderer function #266

Closed
web-padawan opened this issue Oct 13, 2020 · 5 comments
Closed

Create helpers for using Lit templates instead of renderer function #266

web-padawan opened this issue Oct 13, 2020 · 5 comments
Assignees
@vursen
Labels
enhancement New feature or request typescript TypeScript definitions issue

Comments

@web-padawan
Copy link
Member

web-padawan commented Oct 13, 2020 •
edited
Loading

As a LitElement user I want to configure Vaadin components html tagged literals and not renderer functions.

Components affected

Expectations

  • this can be implemented as opt-in feature, for example as a set of lit-html directives that use renderer internally
  • need to make sure eventContext is handled properly. Current DX for it is quite painful: 1, 2
@web-padawan web-padawan self-assigned this Oct 16, 2020
@web-padawan web-padawan changed the title Create helpers for using lit-html templates instead of renderer function Create helpers for using Lit templates instead of renderer function Apr 28, 2021
@web-padawan web-padawan transferred this issue from vaadin/vaadin-core Apr 28, 2021
@web-padawan web-padawan removed their assignment Apr 28, 2021
@web-padawan web-padawan added the enhancement New feature or request label Apr 28, 2021
@web-padawan
Copy link
Member Author

Prototype using Lit 2 pre-release: https://github.com/web-padawan/lit-vaadin-helpers

@web-padawan web-padawan mentioned this issue Apr 29, 2021
Closed
@web-padawan web-padawan added the no-polymer Removing Polymer from Vaadin public APIs label Apr 29, 2021
@web-padawan
Copy link
Member Author

Published [email protected] which is an early preview (pre-alpha) version of helpers.

@web-padawan
Copy link
Member Author

Related issue for vaadin-grid-pro: #366

@web-padawan web-padawan added the typescript TypeScript definitions issue label Aug 24, 2021
@yuriy-fix yuriy-fix removed the v23 label Oct 18, 2021
@web-padawan web-padawan mentioned this issue Dec 14, 2021
Closed
@web-padawan web-padawan mentioned this issue Apr 11, 2022
Merged
@web-padawan
Copy link
Member Author

WIP branch: https://github.com/vaadin/web-components/tree/feat/lit-renderer

@vursen vursen self-assigned this Apr 26, 2022
This was referenced Apr 27, 2022
Merged
Merged
Merged
This was referenced May 3, 2022
Merged
Merged
Merged
Merged
@web-padawan web-padawan mentioned this issue May 4, 2022
Merged
@web-padawan web-padawan removed the no-polymer Removing Polymer from Vaadin public APIs label May 4, 2022
This was referenced May 4, 2022
Merged
Closed
@vursen
Copy link
Contributor

vursen commented May 5, 2022 •
edited
Loading

Created a ticket to not forget about documentation for Lit directives: vaadin/docs#1356

@web-padawan web-padawan mentioned this issue May 10, 2022
Merged
@vursen vursen closed this as completed May 12, 2022
@web-padawan web-padawan mentioned this issue Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vursen vursen

Labels
enhancement New feature or request typescript TypeScript definitions issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vursen @web-padawan @yuriy-fix