-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Lit renderer directives for dialog #3755
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a505c2
to
7496188
Compare
vursen
commented
Apr 30, 2022
vursen
commented
Apr 30, 2022
vursen
commented
Apr 30, 2022
bce0012
to
12f6a25
Compare
d6999ed
to
28c3d99
Compare
sissbruecker
reviewed
May 3, 2022
web-padawan
reviewed
May 3, 2022
e5a2c7f
to
4db316e
Compare
web-padawan
approved these changes
May 3, 2022
tomivirkki
reviewed
May 3, 2022
sissbruecker
reviewed
May 3, 2022
sissbruecker
approved these changes
May 3, 2022
tomivirkki
approved these changes
May 3, 2022
77594ef
to
0e2c971
Compare
Kudos, SonarCloud Quality Gate passed!
|
This was referenced May 3, 2022
This ticket/PR has been released with Vaadin 23.1.0.beta1 and is also targeting the upcoming stable 23.1.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a Lit renderer directive for each renderer property of the dialog component in order to provide a better DX for Lit users.
Part of #266
Dialog Content Renderer
Dialog Header Renderer
Dialog Footer Renderer
Type of change
Checklist