You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, Grid tries to set new items and update the size whenever a data provider callback is called, regardless if there is a corresponding pending page request. This has at least several negative consequences:
Data is accepted even if the same data provider callback was already called once.
Data is accepted even if the cache was cleared while the page request was pending.
Besides, this doesn't align with combo-box which ignores such callback invocations.
Expected outcome
Invocations of a data provider callback should be ignored if that callback isn't present in the page queue.
vursen
changed the title
[grid] Should not accept data from data provider callback when there is no corresponding page request
[grid] Should not accept data from stale data provider callbacks
Nov 24, 2023
vursen
changed the title
[grid] Should not accept data from stale data provider callbacks
[grid] Should not accept data from data provider callbacks that were used once
Nov 24, 2023
vursen
changed the title
[grid] Should not accept data from data provider callbacks that were used once
[grid] Should not accept data from data provider callbacks that were already used
Nov 24, 2023
Description
A finding from #5961:
Currently, Grid tries to set new items and update the size whenever a data provider callback is called, regardless if there is a corresponding pending page request. This has at least several negative consequences:
Besides, this doesn't align with
combo-box
which ignores such callback invocations.Expected outcome
Invocations of a data provider callback should be ignored if that callback isn't present in the page queue.
Here is how it's done in
combo-box
:web-components/packages/combo-box/src/vaadin-combo-box-data-provider-mixin.js
Lines 180 to 183 in d71cf05
Minimal reproducible example
Steps to reproduce
Environment
Vaadin version(s): 24.3 and earlier
OS: Mac OS
Browsers
Issue is not browser related
The text was updated successfully, but these errors were encountered: