Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore data from re-invoked callbacks #6968

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Dec 15, 2023

Description

The PR adds a check to DataProviderController to ignore data from callbacks that have been already invoked once before.

Fixes #6584

Type of change

  • Bugfix

@vursen vursen changed the title fix: ignore data from already once invoked callbacks fix: ignore data from re-invoked callbacks Dec 15, 2023
@vursen vursen requested a review from tomivirkki December 15, 2023 08:47
@vursen vursen marked this pull request as ready for review December 15, 2023 08:48
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vursen vursen merged commit f349a02 into main Dec 15, 2023
9 checks passed
@vursen vursen deleted the ignore-already-invoked-callbacks branch December 15, 2023 10:32
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[grid] Should not accept data from data provider callbacks that were already used
3 participants