-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref!: convert internal grid templates to renderers #1967
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
806c896
to
adc96bf
Compare
vursen
commented
May 21, 2021
vursen
commented
May 21, 2021
adc96bf
to
ae672b6
Compare
tomivirkki
reviewed
May 24, 2021
ae672b6
to
c57394c
Compare
1f96d3c
to
5e5087a
Compare
24f1c07
to
507361d
Compare
vursen
commented
May 26, 2021
tomivirkki
reviewed
May 26, 2021
54e705c
to
c959eab
Compare
c959eab
to
f78582b
Compare
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
May 26, 2021
web-padawan
approved these changes
May 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
7 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, some internal grid components used Polymer templates to render a pre-defined cell content.
The PR introduces the concept of default renders and converts all the internal grid templates to default renderers.
vaadin-grid-selection-column
(see breaking change below)vaadin-grid-filter-column
vaadin-grid-sort-column
vaadin-grid-tree-column
Fixes #1963
Related to #326 (removing the Polymer Template API from grids)
Computed renderers
I found the logic of computing a final renderer to render is quite messy and not obvious to work with. The renderers used to be re-assigned in different observers, so that made it hard to know which renderer is being used at the moment.
After a refactoring, all such the logic has been moved to computed properties, e.g:
__computeHeaderRenderer
__computeRenderer
__computeFooterRenderer
Breaking change in the Selection Column
Setting the
path
property for the selection column is no longer supported.Before:
After:
Type of change
Checklist