refactor: update grid dragover=on-top visual style (Lumo) #2647
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
||
| [part~='row'][dragstart] { | ||
| /* Add bottom-space to the row so the drag number doesn't get clipped. Needed for IE/Edge */ | ||
| border-bottom: 100px solid transparent; |
There was a problem hiding this comment.
This removal probably also fixes #2124
There was a problem hiding this comment.
Yeah, that crossed my mind as well, but I didn't see if it has any impact there. I’ll do that now.
There was a problem hiding this comment.
Hmm, actually, I can't reproduce the bug in start.vaadin.com anymore, using Safari 15. So I can't make sure if this PR actually fixes the issue. Can you test it?
There was a problem hiding this comment.
I tested on Safari 15 and 14 but couldn't reproduce
There was a problem hiding this comment.
The implementation/styling of that part of start.vaadin.com has changed as well, so it’s hard to test anymore.
|
This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version. |
Reduce the opacity of the drag overlay when
dragover="on-top".Extend the drag overlay to cover the frozen column divider (right border of the last frozen column), so that the overlay is perceived as one single element on top of all columns (no gaps).
Remove unnecessary styles that target IE/Edge (no longer supported).
This PR is required before merging #2626 (see #2626 (comment)).