New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing checked property to type declarations #2843

Merged

web-padawan merged 3 commits into master from regression/checkbox/missing-types

Oct 13, 2021

Contributor

vursen commented Oct 13, 2021 •

edited

Loading

Description

The PR adds the missing checked property to the CheckedMixin type declarations.

Fixes #2842

Type of change

Bugfix

Checklist

I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
I have added a description following the guideline.
The issue is created in the corresponding repository and I have referenced it.
I have added tests to ensure my change is effective and works as intended.
New and existing tests are passing locally with my change.
I have performed self-review and corrected misspellings.

vursen added 3 commits

October 13, 2021 11:01


          test: add missing types tests for checkbox

7bf2dbe


          test: add missing types tests for radio-button

237bc44


          fix: add missing checked property to CheckedMixin type declarations

4700eae

vursen requested a review from web-padawan

October 13, 2021 08:05

sonarqubecloud bot commented Oct 13, 2021

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

web-padawan approved these changes

View reviewed changes

web-padawan merged commit 51e232a into master

web-padawan deleted the regression/checkbox/missing-types branch

October 13, 2021 08:21

vaadin-bot added prerelease version for platform 22.0.0 Released with Platform 22.0.0.alpha8 labels

Collaborator

vaadin-bot commented Oct 18, 2021

This ticket/PR has been released with platform 22.0.0.alpha8 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prerelease version for platform 22.0.0 Released with Platform 22.0.0.alpha8