Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract helper logic to HelperController #3185

Merged
merged 4 commits into from
Jan 6, 2022
Merged

refactor: extract helper logic to HelperController #3185

merged 4 commits into from
Jan 6, 2022

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Dec 13, 2021 •
edited
Loading

Description

Updated FieldMixin to use HelperController for handling helper, similarly to LabelController.

Type of change

  • Refactor

@web-padawan web-padawan added the a11y Accessibility issue label Dec 13, 2021
@web-padawan web-padawan force-pushed the refactor/helper-slot-controller branch 3 times, most recently from 375daea to 75ea754 Compare December 14, 2021 11:53
@web-padawan web-padawan mentioned this pull request Dec 15, 2021
Merged
@web-padawan web-padawan force-pushed the refactor/helper-slot-controller branch 3 times, most recently from ac60f96 to 8487411 Compare December 22, 2021 14:28
@web-padawan web-padawan marked this pull request as ready for review December 22, 2021 14:28
vursen
vursen reviewed Dec 22, 2021
View reviewed changes
@web-padawan web-padawan force-pushed the refactor/helper-slot-controller branch from 8487411 to e5730b6 Compare January 3, 2022 13:35
@web-padawan web-padawan requested review from vursen and removed request for tomivirkki January 5, 2022 13:06
@web-padawan @vursen
Apply suggestions from code review
7c3f13e 
Co-authored-by: Sergey Vinogradov <[email protected]>
@web-padawan web-padawan requested a review from vursen January 6, 2022 18:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit e27838e into master Jan 6, 2022
@web-padawan web-padawan deleted the refactor/helper-slot-controller branch January 6, 2022 21:33
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick e27838e
error: could not apply e27838e... refactor: extract helper logic to HelperController (#3185)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@web-padawan web-padawan mentioned this pull request Jan 7, 2022
Merged
web-padawan added a commit that referenced this pull request Jan 10, 2022
@web-padawan
refactor: extract helper logic to HelperController (#3185)
834f81d
@web-padawan web-padawan mentioned this pull request Jan 10, 2022
Merged
web-padawan added a commit that referenced this pull request Jan 10, 2022
@web-padawan
refactor: extract helper logic to HelperController (#3185) (#3277)
39a4276
@web-padawan web-padawan mentioned this pull request May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen vursen approved these changes

Assignees
No one assigned
Labels
cherry-picked-22.0 target/22.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web-padawan @vaadin-bot @vursen