feat: add default size for map component #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
commented
Feb 17, 2022
Comment on lines
+67
to
+68
| flex: 1 1 auto; | ||
| align-self: stretch; |
There was a problem hiding this comment.
Aligned the flex properties with Grid. Not sure if we had issues with Grid in that regard, but they seem reasonable to have.
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Feb 18, 2022
|
This ticket/PR has been released with platform 23.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a default size for the map component. The element already was a block element, which covers width. For height the element should align with Grid and Charts, which both have a default height of 400px.
Fixes #3449
Type of change