fix: check last custom value on focusout #3485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
sissbruecker
approved these changes
Feb 23, 2022
web-padawan
added a commit
that referenced
this pull request
Feb 25, 2022
web-padawan
added a commit
that referenced
this pull request
Feb 25, 2022
|
This ticket/PR has been released with platform 23.0.0.rc1 and is also targeting the upcoming stable 23.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the original fix to only check last custom value on
focusoutwhere the actual problem manifested.To me it seems like a cleaner approach than attempting to reset that flag in all the possible cases.
Fixes vaadin/flow-components#2523
Type of change