-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update select to not use button #3612
Conversation
d55e82c
to
83f4996
Compare
Regression: The select loses focus after pressing Enter or Space several timesSteps:
Actual: The select component loses focus after you press an activation key several times. Expected: The select component keeps focused regardless of how many times you press an activation key. Recording: Screen.Recording.2022-03-28.at.16.05.19.movSnippet: <script type="module">
import '@vaadin/select';
</script>
<vaadin-select label="New"></vaadin-select>
<script>
const select = document.querySelector('vaadin-select');
select.renderer = (root, _, model) => {
root.innerHTML = `
<vaadin-list-box>
<vaadin-item value="xs" disabled>XS (out of stock)</vaadin-item>
<vaadin-item value="s">S</vaadin-item>
<vaadin-item value="m">M</vaadin-item>
<vaadin-item value="l">L</vaadin-item>
<vaadin-item value="xl">XL</vaadin-item>
</vaadin-list-box>
`;
};
</script> |
83f4996
to
b42361c
Compare
@vursen Updated the code to use |
b42361c
to
c1654bc
Compare
a8eae85
to
2959229
Compare
0d4f228
to
eb51b9f
Compare
Kudos, SonarCloud Quality Gate passed!
|
This ticket/PR has been released with Vaadin 23.1.0.alpha2 and is also targeting the upcoming stable 23.1.0 version. |
Description
Updated
vaadin-select-value-button
to use mixins instead of extendingvaadin-button
directly.Fixes #3607
Type of change