-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show dropdown with selected items when readonly #3686
Conversation
If I can wish, I would also hide the clear button in the chips ( |
585ee9b
to
33924ea
Compare
Thanks, done. Also updated themes to hide it when disabled for consistency. |
It’s a visual indication that there are multiple "collapsed/stacked" chips, not just one. |
Actually, it's kind of a feature, related to another PR in review - please see #3632. Here is the original design for this extra border: vaadin/platform#2690 (comment) |
Ah, right. :) |
I am thinking that the toggle button color could be in a different shade. Maybe the same as the color when it's not on ready only state. My feeling is that with the current color, it doesn't clearly indicate it's clickable (and might even fail some a11y contrast test, but I didn't test it yet). |
Good catch. Updated Lumo and Material themes accordingly. |
For a multi select with no items selected, the overlay opens with all the options. multi-select-empty-read-only.mp4 |
@DiegoCardoso Thanks, fixed. Also updated toggle button styles to use |
nit: maybe we can change the cursor to default here multi-select-read-only-material.mp4. |
bc64e82
to
25236ae
Compare
25236ae
to
a1295c8
Compare
@DiegoCardoso Thanks, fixed. |
Kudos, SonarCloud Quality Gate passed!
|
This ticket/PR has been released with Vaadin 23.1.0.alpha4 and is also targeting the upcoming stable 23.1.0 version. |
@web-padawan looks like this feature doesn't work (can be reproduced in the docs and was reported here vaadin/platform#3257) |
Thanks. It's also reported here: vaadin/flow-components#3684. We will look into it. |
Description
As discussed internally, the dropdown should be also available when readonly, so user can see all the selected items.
In this case, interacting with the items isn't possible: you can't un-select them with keyboard or mouse click.
Type of change