fix: clear filter when clicking matching value

[web-padawan]

Description

The issue with not clearing the input was coming from the fact that by default, clear() method only sets 'value' to empty string. However, it was already empty for an internal combo-box, so the observer to reset input value wasn't triggered.

Updated to manually set inputElement.value to empty string. Also, added logic to reset filter property, so that the component shows all the items after clicking / pressing Enter on the matching item in the dropdown.

Fixes #3644

Type of change

• Bugfix

[vursen]

Verified by manual testing that the PR solves the issue.

The only thing I'm not sure that I totally understand: what is the difference between the clear and _clear methods? They are both in the same scope.

web-components/packages/multi-select-combo-box/src/vaadin-multi-select-combo-box-internal.js

Lines 105 to 115 in 0a9c5e0

	/**
	* @param {!Event} event
	* @protected
	*/
	_onChange(event) {
	super._onChange(event);
	if (this._isClearButton(event)) {
	this._clear();
	}
	}

web-components/packages/multi-select-combo-box/src/vaadin-multi-select-combo-box-internal.js

Lines 84 to 94 in 0a9c5e0

	/**
	* @protected
	* @override
	*/
	clear() {
	super.clear();
	if (this.inputElement) {
	this.inputElement.value = '';
	}
	}

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[web-padawan]

what is the difference between the clear and _clear methods?

Good point. It looks like clear() method coming from InputMixin does not detect and dispatch change event, which makes sense because programmatic value updates should not do that. And _clear method does dispatch change.

BTW, there is a similar __clear()method in InputControlMixin. Because of the way how combo-box should behave, it does not use that method but instead overrides event listeners for Esc and clear button click 🙈

[vaadin-bot]

This ticket/PR has been released with Vaadin 23.1.0.alpha3 and is also targeting the upcoming stable 23.1.0 version.