fix: use solid background for editable cells #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
commented
Apr 28, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
jouni
approved these changes
Apr 29, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 29, 2022
* fix: use solid background for editable cells * revert background-clip changes * make editable cell background cover border as well
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 29, 2022
* fix: use solid background for editable cells * revert background-clip changes * make editable cell background cover border as well
sissbruecker
added a commit
that referenced
this pull request
Apr 29, 2022
* fix: use solid background for editable cells * revert background-clip changes * make editable cell background cover border as well Co-authored-by: Sascha Ißbrücker <[email protected]>
sissbruecker
added a commit
that referenced
this pull request
Apr 29, 2022
* fix: use solid background for editable cells * revert background-clip changes * make editable cell background cover border as well Co-authored-by: Sascha Ißbrücker <[email protected]>
|
This ticket/PR has been released with Vaadin 23.1.0.beta1 and is also targeting the upcoming stable 23.1.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes editable cell styles to use an opaque background on hover / focus, which prevents underlying cells from bleeding into the foreground.
The fix is based on the suggestion by Jouni here: vaadin/flow-components#2365 (comment)
Fixes vaadin/flow-components#2365
Lumo theme:
Bildschirmaufnahme.2022-04-28.um.16.22.03.mp4
Lumo with
highlight-editable-cellstheme variant:Bildschirmaufnahme.2022-04-28.um.16.22.50.mp4
Material theme:
Bildschirmaufnahme.2022-04-28.um.16.39.43.mp4
Type of change