refactor!: align custom value property and event #3846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/msc-custom-value
branch
from
2e4a9c7 to
999a900
Compare
|
Dev page is still using the old name |
|
@tomivirkki Thanks, updated the dev page. |
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
May 13, 2022
|
This ticket/PR has been released with Vaadin 23.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vaadin-multi-select-combo-boxto use same property / event for custom values asvaadin-combo-box.stopPropagation()for the originalcustom-value-setevent to ensure it can't mess up the users logicType of change