Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add more rules to Prettier config, fix warnings (CP: 22.0) #3867

Merged
merged 2 commits into from
May 16, 2022

Conversation

vursen
Copy link
Contributor

@vursen vursen commented May 16, 2022

Description

The PR adds the following rules to the project's Prettier config and fixes the related warnings:

  • tabWidth: 2
  • bracketSpacing: true
  • trailingComma: all

Note, it is not a direct cherry-pick of #3725. I considered that it would be safer to run Prettier for the 22.0 branch individually than to try to resolve a potentially huge number of conflicts.

Related to #3725

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen changed the base branch from master to 22.0 May 16, 2022 10:07
@vursen vursen requested a review from web-padawan May 16, 2022 10:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@web-padawan web-padawan merged commit 97e254c into 22.0 May 16, 2022
@web-padawan web-padawan deleted the cp-22/prettier branch May 16, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants