refactor!: move avatar-group list-box to light DOM #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/avatar-group-overlay-light-dom
branch
2 times, most recently
from
8d0058a to
d5404e5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
12 tasks
web-padawan
force-pushed
the
refactor/avatar-group-overlay-light-dom
branch
from
d5404e5 to
c071c50
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
reviewed
Oct 10, 2022
| <template> | ||
| </template> | ||
| <vaadin-list-box role="list"> | ||
| </vaadin-list-box> |
There was a problem hiding this comment.
nit: How about we add one more test specifically for the overflowing case?
There was a problem hiding this comment.
Good point, we can add it later in a separate PR.
vursen
approved these changes
Oct 10, 2022
web-padawan
added a commit
that referenced
this pull request
Oct 10, 2022
web-padawan
added a commit
that referenced
this pull request
Oct 11, 2022
web-padawan
added a commit
that referenced
this pull request
Oct 12, 2022
web-padawan
added a commit
that referenced
this pull request
Oct 14, 2022
|
This ticket/PR has been released with Vaadin 24.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same as #3904 but for
vaadin-avatar-groupoverlay content (list-box and items).Before
After
Type of change