feat: add missing API related to dataProvider #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
May 30, 2022
| */ | ||
| size: { | ||
| type: Number, | ||
| notify: true, |
There was a problem hiding this comment.
Note: the regular web component does not dispatch size-changed event, so I had to override the property here to specify notify: true - this is done in order to ensure host element size is updated properly.
sissbruecker
approved these changes
May 30, 2022
web-padawan
force-pushed
the
feat/add-missing-api
branch
from
2377806 to
1ba2a2e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with Vaadin 23.1.0.rc2 and is also targeting the upcoming stable 23.1.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the public APIs that are currently missing in
vaadin-multi-select-combo-boxbut are present in the regularvaadin-combo-box, especiallysizeproperty (we have some tests where it's configured) andclearCache()method.Type of change