Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: re-organize and add more snapshot tests #4054

Merged
merged 9 commits into from
Jun 17, 2022
Merged

test: re-organize and add more snapshot tests #4054

merged 9 commits into from
Jun 17, 2022

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jun 17, 2022 •
edited
Loading

Description

  • Re-organized snapshot tests so that there is now a common host suite that tests both the host element and slots at the same time.
  • Added tests verifying that the error message id is associated with the input when the field is invalid.

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen requested a review from web-padawan June 17, 2022 10:10
@vursen vursen marked this pull request as ready for review June 17, 2022 10:10
@vursen vursen mentioned this pull request Jun 17, 2022
Merged
7 tasks
@web-padawan web-padawan merged commit 9720d8a into master Jun 17, 2022
@web-padawan web-padawan deleted the test/re-organize-snapshot-tests branch June 17, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vursen @web-padawan