fix: accept boolean and numeric item values

[cromoteca]

Description

When the vaadin-select component receives a value which is not a string, it should be able to find the corresponding item anyway. This fix simply convert the new value to string before searching for it. This will also allow Hilla to bind selects to boolean and integers.

Fixes #4059

Type of change

• Bugfix
• Feature

Checklist

• I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
• I have added a description following the guideline.
• The issue is created in the corresponding repository and I have referenced it.
• I have added tests to ensure my change is effective and works as intended.
• New and existing tests are passing locally with my change.
• I have performed self-review and corrected misspellings.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[web-padawan]

LGTM. I'm not sure if using true and false as vaadin-item values is something we should promote in the docs (personally, I would use a checkbox). But it's a relatively small feature so 🤷‍♂️

[cromoteca]

I agree with you. The need came from vaadin/hilla#177. Might be a bit more useful with numbers anyway.

[tomivirkki]

Is a similar change planned for components other than <vaadin-select>?

For example, in the following cases:

<vaadin-radio-group label="Travel class">
  <vaadin-radio-button value="1" label="Economy"></vaadin-radio-button>
  <vaadin-radio-button value="2" label="Business"></vaadin-radio-button>
</vaadin-radio-group>

comboBox.items = [
  {
    label: 'foo',
    value: '1',
  },
  {
    label: 'bar',
    value: '2',
  },
];

...this works: component.value = '1'
but this doesn't: component.value = 1

[web-padawan]

There is an issue for supporting array of numbers in vaadin-combo-box: #1379