refactor!: move menu-bar buttons to light DOM #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/menu-bar-light-dom
branch
3 times, most recently
from
0284209 to
d74917a
Compare
web-padawan
force-pushed
the
refactor/menu-bar-light-dom
branch
from
d74917a to
899a087
Compare
vursen
reviewed
Oct 18, 2022
vursen
reviewed
Oct 18, 2022
web-padawan
force-pushed
the
refactor/menu-bar-light-dom
branch
from
899a087 to
b5f9a3f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
sissbruecker
approved these changes
Oct 19, 2022
vursen
approved these changes
Oct 19, 2022
|
This ticket/PR has been released with Vaadin 24.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4292
Based on the previous prototype: 6f44273
Type of change