Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix components dev dependencies used in tests #4736

Merged
merged 2 commits into from
Oct 13, 2022
Merged

chore: fix components dev dependencies used in tests #4736

merged 2 commits into from
Oct 13, 2022

Conversation

web-padawan
Copy link
Member

Description

  • Added missing @vaadin/checkbox-group dependency imported in field-components.test.js
  • Fixed import of vaadin-text-field to use non-prefixed version in field-highlighter.test.js

Type of change

  • Internal change

Note

This issue was discovered when trying to use pnpm instead of yarn as it fails to resolve these imports.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit 84a77a8 into master Oct 13, 2022
@web-padawan web-padawan deleted the chore/field-highlighter-deps branch October 13, 2022 11:22
@web-padawan web-padawan mentioned this pull request Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sissbruecker sissbruecker sissbruecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@web-padawan @sissbruecker