Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add component-base dependency used in tests #4745

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

web-padawan
Copy link
Member

Description

Added @vaadin/component-base dependency to integer-field package, as it's used in snapshot tests:

import { resetUniqueId } from '@vaadin/component-base/src/unique-id-utils.js';

This is aligned with email-field package that also imports corresponding dependency only in snapshot tests.

Type of change

  • Internal change

Note

This was discovered when trying to use pnpm instead of yarn as it fails to resolve this dependency.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit 5b530e5 into master Oct 13, 2022
@web-padawan web-padawan deleted the chore/integer-field-dep branch October 13, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants