test: reorganize and cleanup date-picker tests #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
commented
Oct 20, 2022
| import * as settings from '@polymer/polymer/lib/utils/settings.js'; | ||
| import { close, getFocusedCell, getOverlayContent, idleCallback, open } from './common.js'; | ||
|
|
||
| settings.setCancelSyntheticClickEvents(false); |
There was a problem hiding this comment.
This is no longer needed here, because we enable it in ElementMixin since #3510
Comment on lines
-573
to
-576
| it('should open by tapping the calendar icon even if autoOpenDisabled is true', async () => { | ||
| tap(toggleButton); | ||
| await oneEvent(datepicker.$.overlay, 'vaadin-overlay-open'); | ||
| }); |
There was a problem hiding this comment.
Removed this duplicate test, because autoOpenDisabled has no effect on the toggle button.
tomivirkki
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorganized
vaadin-date-pickerunit tests for better readability:fullscreentests to separate suite and changed to usesetViewportcommand,setTimeout,setCancelSyntheticClickEvents(false)from one test suite,document.activeElementinstead ofisFocusedhelper,Type of change