Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update input-container Lumo test screenshots #4813

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

web-padawan
Copy link
Member

Description

For some reason, the visual tests for vaadin-input-container started to fail with the following error:

VisualRegressionError: Screenshot is not the same width and height as the baseline. Baseline: { width: 231, height: 56 }Screenshot: { width: 233, height: 56 }
    at Object.visualDiffCommand (/Users/serhii/vaadin/web-components/node_modules/@web/test-runner-visual-regression/dist/visualDiffCommand.js:70:15)
    at async TestRunnerApiPlugin._onCommand (/Users/serhii/vaadin/web-components/node_modules/@web/test-runner-core/dist/server/plugins/api/testRunnerApiPlugin.js:145:32)

Updated the screenshots to see what has changed. Also added the autoload import for font styles.

Type of change

  • Test

@web-padawan web-padawan requested a review from vursen October 24, 2022 07:59
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan removed the request for review from vursen October 24, 2022 13:32
@web-padawan web-padawan merged commit 173376f into master Oct 24, 2022
@web-padawan web-padawan deleted the test/input-container-lumo branch October 24, 2022 13:32
web-padawan added a commit that referenced this pull request Oct 24, 2022
web-padawan added a commit that referenced this pull request Oct 24, 2022
web-padawan added a commit that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants