fix: hide tooltip while scrolling #4819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
sissbruecker
commented
Oct 25, 2022
| @@ -209,6 +211,39 @@ describe('tooltip', () => { | |||
| expect(tooltip.opened).to.be.false; | |||
| }); | |||
|
|
|||
| it('should hide the tooltip when starting scrolling', async () => { | |||
There was a problem hiding this comment.
This also solves an issue in Safari which does not trigger mouseenter while scrolling (with a trackpad at least):
Bildschirmaufnahme.2022-10-25.um.10.04.10.mov
Comment on lines
3
to
-8
| export const flushGrid = (grid) => { | ||
| grid._observer.flush(); | ||
| grid._afterScroll(); | ||
| if (grid._debounceScrolling) { | ||
| grid._debounceScrolling.flush(); | ||
| } | ||
| grid._afterScroll(); |
There was a problem hiding this comment.
Fixes flushGrid to also clear the scrolling attribute.
web-padawan
approved these changes
Oct 25, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
web-padawan
pushed a commit
that referenced
this pull request
Oct 25, 2022
) Co-authored-by: Sascha Ißbrücker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes the grid's tooltip when the user starts scrolling to prevent the tooltip overlay from blocking scroll events on the grid. When using keyboard navigation the tooltip is not closed. While scrolling, the tooltip is not opened again on
mouseenterto avoid the tooltip rapidly opening and closing.Fixes #4766
Type of change