Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove deprecated vaadin- prefixed packages #4844

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

web-padawan
Copy link
Member

Description

  1. Removed all the @vaadin/vaadin- components packages that have been deprecated previously,
  2. Removed no longer needed "smoke" tests that were checking old / renamed component exports.

Type of change

  • Breaking change

Note

The following packages are not removed as we will keep them in Vaadin 24 for backwards compatibility:

  • @vaadin/vaadin-lumo-styles
  • @vaadin/vaadin-material-styles
  • @vaadin/vaadin-themable-mixin

There is also @vaadin/vaadin-list-mixin that is not considered public and might be moved in the future.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jouni
Copy link
Member

jouni commented Oct 26, 2022

Screenshot 2022-10-26 at 10 05 19 👀 😄

One of the largest code deletion PRs I remember.

@web-padawan
Copy link
Member Author

One of the largest code deletion PRs I remember.

Not even close to this one (although it also added some lines, so maybe it doesn't count): vaadin/flow#7230

@web-padawan web-padawan merged commit 36ef621 into master Oct 26, 2022
@web-padawan web-padawan deleted the refactor/drop-legacy-packages branch October 26, 2022 07:44
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants