fix: ignore sorter click if event is canceled #5089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Nov 30, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
tomivirkki
added a commit
that referenced
this pull request
Nov 30, 2022
Co-authored-by: Tomi Virkki <[email protected]>
web-padawan
pushed a commit
that referenced
this pull request
Dec 1, 2022
Co-authored-by: Tomi Virkki <[email protected]>
|
This ticket/PR has been released with Vaadin 24.0.0.alpha6 and is also targeting the upcoming stable 24.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/flow-components#4170
In the case of clicking a
<vaadin-select>(wrapped inside a<vaadin-grid-sorter>), the native focus is moved right away inside the select overlaysorter-select-click.mp4
...so the existing check that reacts on internal focusable clicks didn't stop the event from being consumed by the sorter.
This PR fixes the issue by adding another check which stops the processing in case something else has already canceled the event.
Type of change
Bugfix