Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update ESLint, fix member-ordering warnings #5264

Merged
merged 1 commit into from
Jan 9, 2023
Merged

refactor: update ESLint, fix member-ordering warnings #5264

merged 1 commit into from
Jan 9, 2023

Conversation

web-padawan
Copy link
Member

Description

  1. Updated ESLint and config to align with fix(rules): update "member-ordering" rule eslint-config-vaadin#29.
  2. Fixed member-ordering rule warnings - mainly be placing all the getters and setters before instance methods,
  3. Discovered one issue: Conflicting rules for getters and setters pairs ordering eslint-config-vaadin#33

Type of change

  • Refactor / Internal change

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@web-padawan web-padawan removed the request for review from vursen January 9, 2023 12:37
@web-padawan web-padawan merged commit ba89fda into master Jan 9, 2023
@web-padawan web-padawan deleted the chore/eslint-member-ordering branch January 9, 2023 12:37
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha8 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
prerelease version for Vaadin 24.0.0 Released with Vaadin 24.0.0.alpha8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web-padawan @vaadin-bot @tomivirkki