refactor: move item and list-box extensions to separate files #5352
Conversation
| * | ||
| * @protected | ||
| */ | ||
| declare class ContextMenuItem extends Item {} |
There was a problem hiding this comment.
This class isn't exported because it's considered internal. Also, its name collides with ContextMenuItem type.
Because of it, previously when located in the mixin file, it was named ContextMenuItemElement.
I think we can keep these two classes as "private" for now, because they don't enhance parent classes with any logic. Generally, such components as vaadin-select-item do not provide type definitions at all.
There was a problem hiding this comment.
Well, at least vaadin-context-menu-item is used by the Flow counterpart (it creates a virtual DOM tree of vaadin-context-menu-items which then are assigned via the items array), so it isn't entirely private, but types don't make much sense for Flow, I agree.
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version. |
Description
Pre-requisite for #3010
Moved the components used by
vaadin-context-menuto separate files, like it's done e.g. invaadin-selectpackage.Type of change