Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify _hasInputValue workaround, improve JSDoc #5645

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Mar 9, 2023

Description

The PR documents and simplifies the hasInputValue workaround in date-picker that was introduced in #5625.

Part of #5410

Type of change

  • Refactor

@vursen vursen requested a review from yuriy-fix March 9, 2023 12:46
@vursen vursen marked this pull request as ready for review March 9, 2023 12:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen merged commit a34166f into main Mar 10, 2023
@vursen vursen deleted the refactor/date-picker/improve-has-input-value-fix branch March 10, 2023 08:33
@vursen vursen changed the title refactor: simplify _hasInputValue workaround, improve JSDoc refactor(date-picker): simplify _hasInputValue workaround, improve JSDoc Apr 25, 2023
@vursen vursen changed the title refactor(date-picker): simplify _hasInputValue workaround, improve JSDoc refactor: simplify _hasInputValue workaround, improve JSDoc Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants