Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting error message for login fields #5836

Merged
merged 3 commits into from
May 10, 2023

Conversation

DiegoCardoso
Copy link
Contributor

Description

Adds two properties to the i18n object that allow users to customize the error message when, for instance, the user leaves the field empty.

Fixes #101

Type of change

  • Bugfix
  • Feature

@DiegoCardoso DiegoCardoso changed the title feat: allow setting errorMessage for login fields feat: allow setting error message for login fields May 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Updated snapshots to reduce diff by deleting folder and running the script.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

login: Errors indicated using colour alone
4 participants