Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix incorrect vaadin.com link to styling components #6003

Merged
merged 1 commit into from
Jun 20, 2023
Merged

docs: fix incorrect vaadin.com link to styling components #6003

merged 1 commit into from
Jun 20, 2023

Conversation

web-padawan
Copy link
Member

Description

Current link in the API docs leads to 404 page. Let's fix it so that users can find the docs.

Type of change

  • Documentation

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit c20f38b into main Jun 20, 2023
@web-padawan web-padawan deleted the docs/styling-components-link branch June 20, 2023 12:29
vaadin-bot pushed a commit that referenced this pull request Jun 20, 2023
@web-padawan @vaadin-bot
docs: fix incorrect vaadin.com link to styling components (#6003)
847fa07
vaadin-bot pushed a commit that referenced this pull request Jun 20, 2023
@web-padawan @vaadin-bot
docs: fix incorrect vaadin.com link to styling components (#6003)
9167199
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick c20f38b
error: could not apply c20f38b... docs: fix incorrect vaadin.com link to styling components (#6003)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan added a commit that referenced this pull request Jun 21, 2023
@web-padawan
docs: fix incorrect vaadin.com link to styling components (#6003)
4ba48e2
web-padawan added a commit that referenced this pull request Jun 21, 2023
@vaadin-bot @web-padawan
docs: fix incorrect vaadin.com link to styling components (#6003) (#6004
ad122e3 
)

Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan added a commit that referenced this pull request Jun 21, 2023
@web-padawan
docs: fix incorrect vaadin.com link to styling components (#6003)
eaf4595
web-padawan added a commit that referenced this pull request Jun 21, 2023
@vaadin-bot @web-padawan
docs: fix incorrect vaadin.com link to styling components (#6003) (#6005
e62801e 
)

Co-authored-by: Serhii Kulykov <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen vursen approved these changes

Assignees

@vursen vursen

Labels
cherry-picked-24.0 cherry-picked-24.1 need to pick manually 23.3 prerelease version for Vaadin 24.2.0 Released with Vaadin 24.2.0.alpha1 target/23.3 target/24.0 target/24.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web-padawan @vaadin-bot @vursen