fix: invoke setFocused only on events triggered by focusElement #6060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Jun 26, 2023
web-padawan
approved these changes
Jun 26, 2023
vursen
force-pushed
the
fix/do-not-call-set-focused-when-not-focused
branch
from
9b2be55 to
d0899e5
Compare
vursen
changed the title
vursen
changed the title
vursen
changed the title
vursen
changed the title
vursen
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
commented
Jun 27, 2023
web-padawan
approved these changes
Jun 27, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
vursen
added a commit
that referenced
this pull request
Jun 27, 2023
… (#6068) Co-authored-by: Sergey Vinogradov <[email protected]>
vursen
added a commit
that referenced
this pull request
Jun 27, 2023
… (#6067) Co-authored-by: Sergey Vinogradov <[email protected]>
|
This ticket/PR has been released with Vaadin 24.2.0.alpha2 and is also targeting the upcoming stable 24.2.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR ensures that
setFocused()ofDelegateFocusMixinis only invoked when the focus event is triggered byfocusElement. Components can have multiple focusable elements, e.g. an input element and a custom button in a suffix slot. Previously,setFocused(false)could be also invoked on a focusout triggered by an element other thefocusElement, which led to unexpected validation in certain components.Fixes vaadin/flow-components#5136
Type of change