Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display tooltips over notifications #6074

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

sissbruecker
Copy link
Contributor

@sissbruecker sissbruecker commented Jun 28, 2023

Description

Currently tooltips are always shown below notifications:

This increases the z-index for tooltips to be larger than the one for notifications.

Fixes #5748

Type of change

  • Bugfix

@sissbruecker sissbruecker marked this pull request as draft June 28, 2023 10:22
@sissbruecker sissbruecker marked this pull request as ready for review June 28, 2023 11:21
@sissbruecker sissbruecker requested a review from web-padawan June 29, 2023 07:14
@sissbruecker sissbruecker merged commit 171b663 into main Jun 29, 2023
@sissbruecker sissbruecker deleted the fix/tooltip_notification_ordering branch June 29, 2023 10:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot
Copy link
Collaborator

Hi @sissbruecker , this commit cannot be picked to 24.1 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 171b663
error: could not apply 171b663... fix: display tooltips over notifications (#6074)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

sissbruecker added a commit that referenced this pull request Jun 29, 2023
* fix: display tooltips over notifications

* set manual mode via attribute

(cherry picked from commit 171b663)
web-padawan pushed a commit that referenced this pull request Jun 29, 2023
* fix: display tooltips over notifications

* set manual mode via attribute

(cherry picked from commit 171b663)
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha2 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltips on elements in notifications render below the notification overlay
3 participants