Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update date-picker unit tests, add missing await #6265

Merged
merged 1 commit into from
Jul 31, 2023
Merged

test: update date-picker unit tests, add missing await #6265

merged 1 commit into from
Jul 31, 2023

Conversation

web-padawan
Copy link
Member

Description

Updated vaadin-date-picker unit tests to add missing nextRender() needed for LitElement based version.

Type of change

  • Tests

@web-padawan web-padawan requested a review from vursen July 31, 2023 07:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit 1ee37b0 into main Jul 31, 2023
@web-padawan web-padawan deleted the test/date-picker-await branch July 31, 2023 08:20
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha5 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen vursen approved these changes

Assignees
No one assigned
Labels
prerelease version for Vaadin 24.2.0 Released with Vaadin 24.2.0.alpha5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web-padawan @vaadin-bot @vursen