Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate on value change triggered by arrow key #6476

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix: validate on value change triggered by arrow key #6476

merged 1 commit into from
Sep 13, 2023

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Sep 13, 2023 •
edited
Loading

Description

The PR ensures number-field runs validation when the value change is triggered by ArrowUp or ArrowDown.

Fixes #6430

Type of change

  • Bugfix

@vursen vursen changed the title fix: ensure validation on arrow keys fix: validate on value change triggered by arrow key Sep 13, 2023
@vursen vursen requested a review from web-padawan September 13, 2023 09:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen mentioned this pull request Sep 13, 2023
Merged
1 task
@vursen vursen merged commit 213a602 into main Sep 13, 2023
@vursen vursen deleted the fix/number-field/validate-on-arrow-keys branch September 13, 2023 09:55
vaadin-bot pushed a commit that referenced this pull request Sep 13, 2023
@vursen @vaadin-bot
fix: validate on value change triggered by arrow key (#6476)
d9485be
vaadin-bot pushed a commit that referenced this pull request Sep 13, 2023
@vursen @vaadin-bot
fix: validate on value change triggered by arrow key (#6476)
2af681e
@vaadin-bot
Copy link
Collaborator

Hi @vursen , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 213a602
error: could not apply 213a602... fix: validate on value change triggered by arrow key (#6476)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vursen vursen mentioned this pull request Sep 13, 2023
Merged
1 task
web-padawan pushed a commit that referenced this pull request Sep 13, 2023
@vaadin-bot @vursen
fix: validate on value change triggered by arrow key (#6476) (#6477)
ad92847 
Co-authored-by: Sergey Vinogradov <[email protected]>
web-padawan pushed a commit that referenced this pull request Sep 13, 2023
@vaadin-bot @vursen
fix: validate on value change triggered by arrow key (#6476) (#6478)
a6e60ac 
Co-authored-by: Sergey Vinogradov <[email protected]>
web-padawan pushed a commit that referenced this pull request Sep 13, 2023
@vursen
fix: validate on value change triggered by arrow key (#6476) (#6479)
f7fcc7a
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha11 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.0 cherry-picked-24.1 need to pick manually 23.3 prerelease version for Vaadin 24.2.0 Released with Vaadin 24.2.0.alpha11 target/23.3 target/24.0 target/24.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[number-field] Missing validation on change when using keyboard stepping
3 participants
@vursen @vaadin-bot @web-padawan