Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: toolbar should have role="toolbar" for better screen reader support #6499

Merged
merged 1 commit into from
Sep 15, 2023
Merged

fix: toolbar should have role="toolbar" for better screen reader support #6499

merged 1 commit into from
Sep 15, 2023

Conversation

sujoykd
Copy link
Collaborator

@sujoykd sujoykd commented Sep 15, 2023

Description

Fixes #6391

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit 3674c9d into main Sep 15, 2023
@web-padawan web-padawan deleted the fix/rte-toolbar-role branch September 15, 2023 13:45
vaadin-bot pushed a commit that referenced this pull request Sep 15, 2023
@sujoykd @vaadin-bot
fix: set toolbar role on the toolbar buttons container (#6499)
2f12bd0
vaadin-bot pushed a commit that referenced this pull request Sep 15, 2023
@sujoykd @vaadin-bot
fix: set toolbar role on the toolbar buttons container (#6499)
64de32c
web-padawan pushed a commit that referenced this pull request Sep 15, 2023
@vaadin-bot @sujoykd
fix: set toolbar role on the toolbar buttons container (#6499) (#6501)
159209c 
Co-authored-by: sujoykd <[email protected]>
web-padawan pushed a commit that referenced this pull request Sep 15, 2023
@vaadin-bot @sujoykd
fix: set toolbar role on the toolbar buttons container (#6499) (#6500)
31a69a9 
Co-authored-by: sujoykd <[email protected]>
ghost pushed a commit to dethell/web-components that referenced this pull request Sep 26, 2023
@sujoykd @dethell
fix: set toolbar role on the toolbar buttons container (vaadin#6499)
aa619b0
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.beta1 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
cherry-picked-23.3 cherry-picked-24.1 prerelease version for Vaadin 24.2.0 Released with Vaadin 24.2.0.beta1 target/23.3 target/24.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTE toolbar should have role="toolbar"
3 participants
@sujoykd @vaadin-bot @web-padawan