Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visually hide virtualizer placeholders #6600

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented Oct 5, 2023

Description

When a virtualizer item is a placeholder, it should be visually hidden to avoid unnecessary jumpiness.

Fixes vaadin/react-components#88
Fixes #5982

Type of change

Bugfix

@tomivirkki tomivirkki marked this pull request as draft October 5, 2023 13:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki tomivirkki force-pushed the fix/virtualizer/placeholder-visibility branch from a441c39 to ab813af Compare February 22, 2024 13:27
@tomivirkki tomivirkki marked this pull request as ready for review February 22, 2024 13:31
@tomivirkki tomivirkki merged commit 0344d74 into main Feb 22, 2024
8 checks passed
@tomivirkki tomivirkki deleted the fix/virtualizer/placeholder-visibility branch February 22, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants