fix: update grid header and footer on column tree update

[tomivirkki]

Description

Run header and footer renderers after grid column tree update. This ensures that header/footer content updates for a hidden column are applied when the column becomes visible again.

Fixes vaadin/flow-components#5516

Type of change

Bugfix

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[DiegoCardoso]

LGTM

nit: I wonder if a test that only changes the content of the header, but without changing the renderer function could be added, since that's what happens in the FC.

[tomivirkki]

nit: I wonder if a test that only changes the content of the header, but without changing the renderer function could be added, since that's what happens in the FC.

If I understood correctly, in FC's case, the headerRenderer always gets replaced in the connector even on a simple content change.

[DiegoCardoso]

If I understood correctly, in FC's case, the headerRenderer always gets replaced in the connector even on a simple content change.

You are correct. I checked from the function that this single time renderer calls, but assumed that the renderer itself didn't change between calls. Checking it more closely I see that the whole renderer is replaced when a new header content is defined on the server side. I read "single time renderer" as is "single used by a column".

[vaadin-bot]

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 24.1, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick c60f2ae
error: could not apply c60f2ae... fix: update grid header and footer on column tree change (#6648)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

[vaadin-bot]

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 23.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick c60f2ae
error: could not apply c60f2ae... fix: update grid header and footer on column tree change (#6648)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version.

[SonReimer]

I which version will this be backported to 23.3.x ?

[tomivirkki]

I which version will this be backported to 23.3.x ?

Released with Vaadin 23.3.27