fix: only replace double spaces on rte delta conversion #6652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Oct 16, 2023
tomivirkki
added a commit
that referenced
this pull request
Oct 17, 2023
tomivirkki
added a commit
that referenced
this pull request
Oct 17, 2023
tomivirkki
added a commit
that referenced
this pull request
Oct 17, 2023
This was referenced Oct 17, 2023
|
This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression from #6651 where temporarily replacing all space characters in the HTML before delta conversion might change the semantics of the original HTML:
Example:
would become invalid in case the space between the tag name and the attribute was replaced.
This PR fixes the issue by making the logic not replace all space characters (
Type of change
Bugfix